Skip to content

Add portable ELU implementation + test#9520

Merged
swolchok merged 4 commits intomainfrom
gh/swolchok/390/head
Mar 26, 2025
Merged

Add portable ELU implementation + test#9520
swolchok merged 4 commits intomainfrom
gh/swolchok/390/head

Conversation

@swolchok
Copy link
Copy Markdown
Contributor

@swolchok swolchok commented Mar 22, 2025 •
edited
Loading

No description provided.

@swolchok
Update
e9a4489 
[ghstack-poisoned]
@swolchok
Copy link
Copy Markdown
Contributor Author

swolchok commented Mar 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9520

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dd30cfa with merge base c43d5ad (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2025
@swolchok swolchok mentioned this pull request Mar 22, 2025
Merged
@swolchok swolchok requested a review from kimishpatel March 22, 2025 00:30
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Mar 22, 2025
@kimishpatel
Copy link
Copy Markdown
Contributor

kimishpatel commented Mar 22, 2025

did we actually decide to make it a portable op @larryliu0820? If we just want to control its decomp behavior we have other ways to do it as well, right?

@swolchok
Copy link
Copy Markdown
Contributor Author

swolchok commented Mar 22, 2025

did we actually decide to make it a portable op @larryliu0820? If we just want to control its decomp behavior we have other ways to do it as well, right?

Do we not need portable op implementations for all core ATen ops?

@kimishpatel
Copy link
Copy Markdown
Contributor

kimishpatel commented Mar 24, 2025

did we actually decide to make it a portable op @larryliu0820? If we just want to control its decomp behavior we have other ways to do it as well, right?

Do we not need portable op implementations for all core ATen ops?

Sorry I should have been more clear. I was actually asking "did we actually decide to it a core aten op?". If so yes

@swolchok
Copy link
Copy Markdown
Contributor Author

swolchok commented Mar 24, 2025

core aten op

@kimishpatel pytorch/pytorch#149684

@swolchok
Update
2ff82d7 
[ghstack-poisoned]
This was referenced Mar 25, 2025
Merged
Merged
@swolchok
Update
aafeb54 
[ghstack-poisoned]
@swolchok
Copy link
Copy Markdown
Contributor Author

swolchok commented Mar 26, 2025

ping reviewers @manuelcandales @kimishpatel

@swolchok
Update
dd30cfa 
[ghstack-poisoned]
@swolchok swolchok merged commit 751e646 into main Mar 26, 2025
81 checks passed
@swolchok swolchok deleted the gh/swolchok/390/head branch March 26, 2025 20:26
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
@swolchok @kirklandsign
Add portable ELU implementation + test (#9520)
f2fae59
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Add portable ELU implementation + test
cc4ebd4 
ghstack-source-id: 542b906
ghstack-comment-id: 2744722038
Pull Request resolved: pytorch/executorch#9520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @kimishpatel @manuelcandales @facebook-github-bot